RFR (xs) 8172246: [TESTBUG] runtime/RedefineTests/RedefinePreviousVersions.java 'Class unloading: has_previous_vers,ions = true' missing from stdout/stderr
David Holmes
david.holmes at oracle.com
Thu Jan 5 00:33:49 UTC 2017
Hi Coleen,
On 5/01/2017 9:05 AM, Coleen Phillimore wrote:
> Summary: add boolean to gate redefinition start
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8172246/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8172246
Minor nit. Please change both:
Thread.currentThread().sleep(10);
to
Thread.sleep(10);
sleep() always applies to the current thread.
Also, as it is a boolean variable style dictates that:
while (Running.running != true) {
be written as:
while (!Running.running) {
One related query with this test: are we guaranteed that the loop of
System.gc() calls will trigger class unloading?
Thanks,
David
> Tested multiple times with new better test code.
>
> Thanks,
> Coleen
More information about the serviceability-dev
mailing list