RFR: JDK-6760477 - Update SA to include stack traces in the heap dump

[Sharath Ballal]

Thanks Jini.  I have addressed both the comments.

> * Looks like the stackTraces array list is unused. 
Done.  The reason of adding this was for use at other places which may require the stack trace.
> * HeapHprofBinWriter.java: Line 764: It might be better to replace 2 * 4 and similar instances with 2 * INT_SIZE.
Done



 

Thanks & Regards,

Sharath Ballal

 

 

From: Jini George 
Sent: Tuesday, May 30, 2017 2:56 PM
To: Sharath Ballal; serviceability-dev at openjdk.java.net
Subject: Re: RFR: JDK-6760477 - Update SA to include stack traces in the heap dump

 

Hi Sharath,

Looks good. A few nits.

* Looks like the stackTraces array list is unused. 

* HeapHprofBinWriter.java: Line 764: It might be better to replace 2 * 4 and similar instances with 2 * INT_SIZE.

Thanks,
Jini.

On 5/29/2017 4:14 PM, Sharath Ballal wrote:

Hi,

 

Pls review the fix for including stack traces in the heap dump in SA.

 

Bug:    https://bugs.openjdk.java.net/browse/JDK-6760477 

Webrev:  HYPERLINK "http://cr.openjdk.java.net/%7Esballal/6760477/webrev.00/"http://cr.openjdk.java.net/~sballal/6760477/webrev.00/ 

 

 

Thanks & Regards,

Sharath Ballal

 

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20170601/4b1964c0/attachment-0001.html>