RFR(M): 8178054: [TESTBUG] Need test for JVM TI IsModifiableModule

Alan Bateman Alan.Bateman at oracle.com
Fri Jun 9 09:38:43 UTC 2017



On 09/06/2017 10:07, serguei.spitsyn at oracle.com wrote:
> Hi Alan,
>
> Thank you for the comments!
>
> I've made a stand-alone IsModifiableModule test and also added 
> "@modules jdk.jdi" to the GetNamedModuleTest.
>
> New webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8178054-jvmti-ismodif.3/ 
>
This mostly looks good.

One suggestion is to drop the "not_a_module" parameter from 
test_is_modifable_module as it is not needed. Instead the test just 
needs to provide any non-Module object to check_is_modifable (it doesn't 
have to a class loader).

-Alan.


More information about the serviceability-dev mailing list