RFR(M): 8178054: [TESTBUG] Need test for JVM TI IsModifiableModule

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Sat Jun 10 11:08:19 UTC 2017



On 6/10/17 00:41, Alan Bateman wrote:
>
>
> On 09/06/2017 19:32, serguei.spitsyn at oracle.com wrote:
>>
>> Ok, I removed the get_class_loader function, replaced the loader with 
>> a class and left alone the "not_a_module" parameter.
>> This is the simplest way to provide a non-module jobject.
>> Otherwise, the JNIEnv parameter has to be passed to the 
>> check_is_modifiable_error_codes .
>> Also, I've done a small refactoring by inlining the 
>> test_is_modifiable_module body into the *_check function.
>>
>> New webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8178054-jvmti-ismodif.4/ 
>>
> I think it looks good now.

Thank you a lot for review and good suggestions!
Serguei

>
> -Alan.



More information about the serviceability-dev mailing list