Low-Overhead Heap Profiling

[Jeremy Manson]

On Fri, Jun 23, 2017 at 3:52 AM, Thomas Schatzl <thomas.schatzl at oracle.com>
wrote:

>
> I looked through https://wiki.openjdk.java.net/display/HotSpot/StyleGui
> de and the rule is to "follow an existing pattern and must have a
> distinct appearance from other names". Which does not help a lot I
> guess :/ The GC team started using upper camel case, e.g.
> SomeOtherConstant, but very likely this is probably not applied
> consistently throughout. So I am fine with not adding another style
> (like kMaxStackDepth with the "k" in front with some unknown meaning)
> is fine.
>


In case you're curious: the k- prefix for constants is found in Hungarian
notation.  It's used as part of Google C++ style to indicate global (for
some definition) variables declared constexpr or const.  See
https://google.github.io/styleguide/cppguide.html#Constant_Names.

Generally, in our patches, we've ping-ponged on use of Hotspot style versus
Google style.  We tend to use Hotspot if it is obvious to us what that is,
but Google otherwise.

Obviously, it should match Hotspot style if it is being submitted, assuming
we can find out what Hotspot style is. :)

Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20170623/8e95a33c/attachment.html>