RFR(s): 8176304: Number of javax/management test fails due to undeclared dependencies

Sergei Kovalev sergei.kovalev at oracle.com
Thu Mar 9 11:05:31 UTC 2017


Hi Daniel,

Thank you for the review. I'v revised dependencies based on you comments 
and made some changes. Please take a look at the result.

http://cr.openjdk.java.net/~skovalev/8176304/webrev.01

-- 
With best regards,
Sergei

07.03.17 18:55, Daniel Fuchs wrote:
> Hi Sergei,
>
> I have several observations:
>
> - AFAIK you don't need to list modules that
>   are required by a module already listed.
>
>   so for instance, if you list jdk.management.agent then
>   you don't need to list java.management or java.management.rmi
>   (unless you need qualified exports from those)
>
> - AFAICS some (most?) of these tests depend on
>   java.management.rmi and not on jdk.management.agent
>
>   Did you try to simply add java.management.rmi first?
>
> best regards,
>
> -- daniel
>
>
> On 07/03/17 15:31, Sergei Kovalev wrote:
>> Hi Team,
>>
>> Please take a look at the fix for javax.management tests.
>>
>> BugID: https://bugs.openjdk.java.net/browse/JDK-8176304
>> Webrev: http://cr.openjdk.java.net/~skovalev/8176304/webrev.00/
>>
>> Issue: number of tests failing with "--limit-module" command line option
>> due to missed dependencies. In general missed dependencies are:
>> jdk.management.agent and jdk.naming.rmi modules.


More information about the serviceability-dev mailing list