RFR (S): 8176831: Dead code: function jmm_GetLoadedClasses is not used in jmm_interface

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Fri Mar 17 01:20:42 UTC 2017


David,

Thank you for the review!


On 3/16/17 18:15, David Holmes wrote:
> Looks good!
>
> Don't forget to update copyright years.

Yes, of course.


Thanks,
Serguei
>
> Thanks,
> David
>
> On 17/03/2017 10:59 AM, serguei.spitsyn at oracle.com wrote:
>> Please, review the jdk 10 fix for:
>>   https://bugs.openjdk.java.net/browse/JDK-8176831
>>
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8176831-jmm-dead.1/ 
>>
>>
>>
>>
>> Summary:
>>
>>   It was found at the review of the 8155672 that the function
>>   jmm_GetLoadedClasses() defined in services/management.cpp
>>   is not really used in the jmm_interface. This function and
>>   dead code associated with its implementation is removed.
>>
>> Testing:
>>   The nsk.monitoring and jtreg jdk_management tests are in progress.
>>
>>
>> Thanks,
>> Serguei
>>
>>
>>
>>



More information about the serviceability-dev mailing list