RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

Alan Bateman Alan.Bateman at oracle.com
Thu Mar 23 07:18:39 UTC 2017


On 22/03/2017 20:09, Igor Ignatyev wrote:

> http://cr.openjdk.java.net/~iignatyev/8177374/webrev.00/index.html
>> 40 lines changed: 26 ins; 13 del; 1 mod;
> Hi all,
>
> could you please review this changeset which fixes in a few jdk_svc tests which were missed by JDK-8176176[1]?
>
> testing: :jdk_svc tests
> webrev: http://cr.openjdk.java.net/~iignatyev/8177374/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8177374
>
The updated @summary tag for test/com/sun/tools/attach/BasicTests.java 
looks really ugly now. Personally I think I would put the summary at the 
end and intent the second line to make it easier to read.

I also see lots of random empty lines introduced. What is the reason to 
put empty lines between the @modules and @library tags? I can see what 
the information tags might be grouped but @library and @modules should 
also be grouped with the @compile/@run/@build).

-Alan


More information about the serviceability-dev mailing list