RFR: JDK-6515161 If remote removeNotificationListener gets SecurityException, client no longer gets notifications

[Daniel Fuchs]

Hi Ujwal,

For consistency I think the new getListenerIds method should:

a) either return an array of Integer, even if it contains only 1
Integer:

   1. The name of the method implies that an array is returned
   2. You will need the array when you call
      connection.removeNotificationListeners anyway.

or b) the other possibility is to remove the 's' at the end of the
method.

Both would be acceptable.

best regards,

-- daniel

On 04/05/17 07:59, Ujwal Vangapally wrote:
> corrected webrev link : 
> http://cr.openjdk.java.net/~uvangapally/webrev/2017/6515161/webrev.00/
> 
> 
> On 5/4/2017 12:14 PM, Ujwal Vangapally wrote:
>>
>> Kindly review the changes made for below bug
>>
>> Problem description and solution are explained in comments section
>>
>> https://bugs.openjdk.java.net/browse/JDK-6515161
>>
>> diff for*ClientNotifForwarder.java *might be a bit confusing as it 
>> shows the method name
>>
>> removeNotificationListener is modified to getListenerIds and new 
>> method removeNotificationListener is introduced.
>>
>> Actual change is new method getListenerIds is introduced and it is 
>> called in removeNotificationListener method without
>>
>> affecting the functionality of removeNotificationListener.
>>
>> webrev : cr.openjdk.java.net/~uvangapally/webrev/2017/6515161/webrev.00/
>>
>> Thanks,
>>
>> Ujwal,
>>
>