[XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

[serguei.spitsyn at oracle.com]

Hello Matthias,

It is great, you are able to push this fix!

Thanks,
Serguei



On 5/22/17 01:49, Baesken, Matthias wrote:
> Hello Serguei,  the  com/sun/jdi  tests were executed ,  same number of  passed and errors in a patched and unpatched JDK .
> We do not need a sponsor because  the change is in JDK not HS .
>
> Best regards, Matthias
>
>
> -----Original Message-----
> From: serguei.spitsyn at oracle.com [mailto:serguei.spitsyn at oracle.com]
> Sent: Freitag, 19. Mai 2017 02:18
> To: Baesken, Matthias <matthias.baesken at sap.com>; Alan Bateman <Alan.Bateman at oracle.com>; core-libs-dev at openjdk.java.net; serviceability-dev at openjdk.java.net
> Cc: Simonis, Volker <volker.simonis at sap.com>
> Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
>
> Hi Matthias,
>
> The fix looks good to me.
> It must be tested at least with the JTreg com/sun/jdi tests.
> Do you need a sponsor?
>
> Thanks,
> Serguei
>
>
>
> On 5/16/17 03:21, Baesken, Matthias wrote:
>>    Sure, I forward it to  serviceability-dev .
>>
>> -----Original Message-----
>> From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
>> Sent: Dienstag, 16. Mai 2017 11:51
>> To: Baesken, Matthias <matthias.baesken at sap.com>; core-libs-dev at openjdk.java.net
>> Cc: Simonis, Volker <volker.simonis at sap.com>
>> Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
>>
>>
>>
>> On 16/05/2017 10:04, Baesken, Matthias wrote:
>>> Hello, could you please review this small change :
>>>
>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/
>>>
>>> it fixes a number of places in   jdk.jdwp.agent   where in case of an error it is attempted to write to NULL .
>>>
>>> Bug :  JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
>>>
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8180413
>>>
>>>
>> Can you bring this to serviceability-dev as that is the mailing list
>> where the JDWP agent is maintained?
>>
>> -Alan