RFR: JDK-6760477 - Update SA to include stack traces in the heap dump

Jini George jini.george at oracle.com
Tue May 30 09:25:38 UTC 2017


Hi Sharath,

Looks good. A few nits.

* Looks like the stackTraces array list is unused.

* HeapHprofBinWriter.java: Line 764: It might be better to replace 2 * 4 
and similar instances with 2 * INT_SIZE.

Thanks,
Jini.

On 5/29/2017 4:14 PM, Sharath Ballal wrote:
>
> Hi,
>
> Pls review the fix for including stack traces in the heap dump in SA.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-6760477
>
> Webrev: http://cr.openjdk.java.net/~sballal/6760477/webrev.00/ 
> <http://cr.openjdk.java.net/%7Esballal/6760477/webrev.00/>
>
> Thanks & Regards,
>
> Sharath Ballal
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20170530/fd52b6d5/attachment.html>


More information about the serviceability-dev mailing list