[PATCH] Unnecessary Amount Of Internal Class Conversion

[serguei.spitsyn at oracle.com]

Hi Alan,

Sorry for the delay (forgot to push the send button).


On 10/30/17 00:52, Alan Bateman wrote:
>
>
> On 27/10/2017 12:08, serguei.spitsyn at oracle.com wrote:
>> Let's check if Alan has a time to look at it.
>> The patch is not that big. Hi Ben,
> There isn't any changes to the hotspot code so one reviewer should be 
> fine.

Ok.
I normally push to the jdk10/hs, so that was thinking it is better to 
have two reviews.


> In any case, I looked through it and it seems okay.

Ok, I'll add you as a reviewer.


> My only comment is that setHasTransformers would be clearer if it were 
> named something like enableClassFileLoadHook as it just enables or 
> disables the CFLH.

Just enableClassFileLoadHook is not good enough as we enable CFLH events 
separately for retransformable and non-retransformable environments.
The name setHasTransformers looks Ok to me as it signals about the 
status change that causes enabling the CFLH events.
I'd suggest to keep it as it is for now.
Please, let me know if it is Ok with you.

> I realize this would mean find a better name for 
> setHasRetransformableTransformers too.

Right.


Thanks,
Serguei

>
> -Alan