RFR : JDK-8024352 - MBeanOperationInfo accepts any int value as "impact"

mandy chung mandy.chung at oracle.com
Thu Nov 9 15:40:48 UTC 2017



On 11/9/17 2:40 AM, Ujwal Vangapally wrote:
> Thanks for the Review Daniel, made changes as suggested.
>
> webrev : 
> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.03/
>

Looks good.

Minor comment: in the new test, it can fold some of the println together 
e.g. line 81 can be merged with line 39 to include the value being 
passed.  Similarly for the println in the main method.

Mandy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20171109/79d3cda5/attachment.html>


More information about the serviceability-dev mailing list