CSR review request for: 8187289 NotifyFramePop request is not cleared if JVMTI_EVENT_FRAME_POP is disabled

[David Holmes]

On 17/11/2017 3:51 PM, serguei.spitsyn at oracle.com wrote:
> The CSR is:
>    https://bugs.openjdk.java.net/browse/JDK-8191467
> 
> I've added Chris and Dan as reviewers and changed the state to "Proposed".

Did you intend to fast-track it? If so it should have been "Finalized" 
not "Proposed".

> Not sure, how it should switch to the "Pended" state.

That for CSR group use [1]:

Pended: The chair or other CSR member has identified an issue with the 
proposal that needs to be addressed before the proposal can be approved.

David

[1] https://wiki.openjdk.java.net/display/csr/Fields+of+a+CSR+Request

> 
> Thanks,
> Serguei
> 
> 
>> Thank you for catching this problem, David!
>>
>> Thanks,
>> Serguei
>>
>>
>>> has no CSR.
>>>
>>> David
>>>
>>>> Thanks,
>>>> Serguei
>>>>
>>>>
>>>> On 11/16/17 17:53, David Holmes wrote:
>>>>> The CSR needs to be created again from the real bug report. 
>>>>> Everyone will need to re-review and re-add any necessary comments.
>>>>>
>>>>> David
>>>>>
>>>>> On 17/11/2017 11:51 AM, David Holmes wrote:
>>>>>> On 17/11/2017 10:25 AM, serguei.spitsyn at oracle.com wrote:
>>>>>>> Dan and Chris
>>>>>>>
>>>>>>> Could one of you, please, review the CSR for 8187289:
>>>>>>> https://bugs-stage.openjdk.java.net/browse/JDK-8191098
>>>>>>>
>>>>>>> Bug is:
>>>>>>> https://bugs-stage.openjdk.java.net/browse/JDK-8187289
>>>>>>
>>>>>> The links above should not be to bugs-stage!
>>>>>>
>>>>>> David
>>>>>>
>>>>>>> Approved webrev:
>>>>>>> http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2017/hotspot/8187289-jvmti-framepop.2/ 
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> This CSR covers a change in behavior, not in the JVMTI spec.
>>>>>>> We decided that the JVMTI NotifyFramePop is intuitive enough and 
>>>>>>> does not need an update.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Serguei
>>>>>>>
>>>>>>>
>>>>>>>
>>>>
>>
>