RFR: 8189069: regression after push of 8187403: "AssertionFailure: addr should be OopHandle"

[Yasumasa Suenaga]

Hi David, Serguei,

> It was a miscommunication between me and Yasumasa.
> I expected him to run all the SA tests before requesting a push.

Sorry, I did not run jtreg about this.
I expected JPRT runs all tests before pushing.


>> The approach seems reasonable though I'm somewhat unclear on what the
>> possibilities for the address are.

Exception stack shows that it was occurred in heap region iteration.
So I guess it might not be OopHandle when the region is not used.


Thanks,

Yasumasa


2017-10-10 13:31 GMT+09:00 serguei.spitsyn at oracle.com
<serguei.spitsyn at oracle.com>:
> Hi David,
>
>
> On 10/9/17 20:19, David Holmes wrote:
>>
>> Hi Yasumasa,
>>
>> On 10/10/2017 12:03 PM, Yasumasa Suenaga wrote:
>>>
>>> Hi all,
>>>
>>> The following serviceability/sa tests are failed after 8187403:
>>
>>
>> Please ensure you add a link to the bug that introduces a failure when
>> creating the new bug - I've added it now.
>
>
> Thanks, David!
> I've also added a link to the original mdash failures.
>
>>> serviceability/sa/TestHeapDumpForInvokeDynamic.java
>>>    serviceability/sa/TestHeapDumpForLargeArray.java
>>>    serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
>>
>>
>> Why was this not detected before 8187403 was pushed?
>
>
> It was a miscommunication between me and Yasumasa.
> I expected him to run all the SA tests before requesting a push.
>
> Thanks,
> Serguei
>
>
>>
>>> These failures are caused by the address of HeapRegion.
>>> The address which is passed to c'tor of HeapRegion might not be
>>> OopHandle.
>>> So we have to switch the method of address calculation.
>>>
>>> I uploaded webrev for this issue. Could you review it?
>>>
>>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8189069/webrev.00/
>>
>>
>> The approach seems reasonable though I'm somewhat unclear on what the
>> possibilities for the address are.
>>
>> Thanks,
>> David
>> -----
>>
>>>
>>> I cannot access JPRT. So I need a sponsor.
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>>
>