RFR : JDK-8044122 MBean access to the PID

Ujwal Vangapally ujwal.vangapally at oracle.com
Tue Oct 10 17:01:24 UTC 2017


Thanks for the review Harsha.

kindly see my comments inline.

On 10/10/2017 5:51 PM, Harsha Wardhana B wrote:
> Hi Ujwal,
>
> Could you please add a test-case to validate your changes? You can 
> spawn a new process and it can exchange its pid to its parent via 
> System.out/in or via sockets.
>
will it be sufficient if I verify that by comparing it with 
ProcessHandle.current().pid()
> Also, VMManagementImpl:145, the change from getProcessId to getVmPid 
> seems unnecessary.
  I will revert it back if not required.
>
> -Harsha
>
>
> On Tuesday 10 October 2017 05:17 PM, Ujwal Vangapally wrote:
>> Kindly review the changes made.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8044122
>>
>> webrev : 
>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.00/
>>
>> CSR : https://bugs.openjdk.java.net/browse/JDK-8189091
>>
>> Thanks,
>>
>> Ujwal.
>>
>



More information about the serviceability-dev mailing list