RFR: 8189069: regression after push of 8187403: "AssertionFailure: addr should be OopHandle"

Jini George jini.george at oracle.com
Wed Oct 11 12:22:10 UTC 2017


Hi Yasumasa,

The changes look fine.

Thanks,
Jini (not a Reviewer).

On 10/10/2017 7:40 AM, serguei.spitsyn at oracle.com wrote:
> Hi Yasumasa,
> 
> Thank you for the quick fix!
> It looks good.
> I'll sponsor your fix after we get at least one more review.
> 
> Thanks,
> Serguei
> 
> 
> On 10/9/17 19:03, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> The following serviceability/sa tests are failed after 8187403:
>>
>>    serviceability/sa/TestHeapDumpForInvokeDynamic.java
>>    serviceability/sa/TestHeapDumpForLargeArray.java
>>    serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
>>
>> These failures are caused by the address of HeapRegion.
>> The address which is passed to c'tor of HeapRegion might not be 
>> OopHandle.
>> So we have to switch the method of address calculation.
>>
>> I uploaded webrev for this issue. Could you review it?
>>
>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8189069/webrev.00/
>>
>>
>> I cannot access JPRT. So I need a sponsor.
>>
>>
>> Thanks,
>>
>> Yasumasa
> 


More information about the serviceability-dev mailing list