RFR: 8189373: jmap -heap exited with error code

David Holmes david.holmes at oracle.com
Thu Oct 19 11:00:55 UTC 2017


I also took a look and it seemed okay - Jini is the expert so that's 
good enough for me. :)

Reviewed.

David

On 19/10/2017 8:57 PM, Jini George wrote:
> Your changes look good to me, Roman.
> 
> Nit: Please do change the copyright year to 2017 in CollectedHeapName.java.
> 
> Thank you,
> Jini (not a Reviewer).
> 
> On 10/18/2017 11:59 PM, Roman Kennke wrote:
>> My recent CMSHeap extraction has broken the JVM servicability agent. 
>> It looks like I actually need a little bit more boilerplate to make it 
>> happy:
>>
>> http://cr.openjdk.java.net/~rkennke/8189373/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Erkennke/8189373/webrev.00/>
>>
>> It does fix the test that's mentioned in the bug report:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8189373
>>
>> Is this the correct way to fix it?
>>
>> Roman
>>
>>


More information about the serviceability-dev mailing list