[8u] RFR for backport of JDK-8177721: Improve diagnostics in sun.management.Agent#startAgent()

Shafi Ahmad shafi.s.ahmad at oracle.com
Wed Oct 25 08:11:47 UTC 2017


Hi,

Please review the backport of "JDK-8177721: Improve diagnostics in sun.management.Agent#startAgent()" to jdk8u-dev.

The backport is not clean as I got the below conflict.
shshahma at slc12kkg:/scratch/shshahma/Java/jdk8u-dev/jdk$ cat src/share/classes/sun/management/Agent.java.rej
--- Agent.java
+++ Agent.java
@@ -665,18 +665,6 @@
         throw new RuntimeException(keyText);
     }
 
-    public static void error(String key, String[] params) {
-        if (params == null || params.length == 0) {
-            error(key);
-        } else {
-            StringBuilder message = new StringBuilder(params[0]);
-            for (int i = 1; i < params.length; i++) {
-                message.append(' ').append(params[i]);
-            }
-            error(key, message.toString());
-        }
-    }
-
     public static void error(String key, String message) {
         String keyText = getText(key);
         System.err.print(getText("agent.err.error") + ": " + keyText); 

Webrev: http://cr.openjdk.java.net/~shshahma/8177721/jdk8u/webrev.00/
Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8177721
Jdk9 review: http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-April/021188.html

Testing: jprt and jtreg test.


Regards,
Shafi


More information about the serviceability-dev mailing list