RFR: (small): JDK-8190307: SA: Sanity tests for the clhsdb commands: universe, intconstant, type

[Jini George]

Thank you for the quick review, David. My comments inline:

On 10/30/2017 11:18 AM, David Holmes wrote:

>> Plus this assumes G1 is being used but Lingered App is started using 
>> the test run vmOptions AFAICS so it would use whatever GC were passed 
>> through, wouldn't it?
> 
> Okay the above are just examples of "int constants" that will be printed 
> when you dump all the "int constants". The G1 constant doesn't indicate 
> (I presume) that G1 is the active GC.

Yes, the int constants contain compile time values and there are entries 
for all the GC types.

> As I said to Sharath it would be good to validate the results of each 
> command separately rather than collectively.

Will do.

Thanks!
- Jini.



> Thanks,
> David
> 
>> ---
>>
>> TestType.java
>>
>> The expected output is not quite so strange, but still could do with 
>> some commentary.
>>
>>    90         Asserts.assertTrue(output.contains("type G1CollectedHeap 
>> CollectedHeap"));
>>
>> Same comment about assuming G1.
>>
>> Thanks,
>> David
>> ------
>>
>> On 30/10/2017 1:44 PM, Jini George wrote:
>>> Hello,
>>>
>>> We have been working on writing sanity tests for the various jhsdb 
>>> clhsdb commands of the SA to improve the robustness of the SA. As a 
>>> part of this, here is a webrev for sanity tests for 3 of the clhsdb 
>>> commands:
>>>
>>> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8190307
>>> webrev: http://cr.openjdk.java.net/~jgeorge/8190307/webrev.00/
>>>
>>> I would like to request for reviews for this simple addition.
>>>
>>> Thank you,
>>> Jini.