PING: RFR: 8175816: SA: HSDB: Compute Liveness results in java.lang.IndexOutOfBoundsException

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Thu Sep 28 23:22:09 UTC 2017


Hi Yasumasa,

The fix looks good to me.
One minor comment:
   Not all imports in the test are ordered correctly.

Thanks,
Serguei


On 9/23/17 05:13, Yasumasa Suenaga wrote:
> Hi Jini,
>
> I've added a test case for this in new webrev.
> This webrev is for consolidated jdk10/hs.
>
>   http://cr.openjdk.java.net/~ysuenaga/JDK-8175816/webrev.01/
>
>
> Thanks,
>
> Yasumasa
>
>
> On 2017/09/22 15:12, Jini George wrote:
>> Hi Yasumasa,
>>
>> Your change looks good. But please do add in a test case for this.
>>
>> Thanks,
>> Jini (not a Reviewer).
>>
>> On 9/21/2017 4:18 AM, Yasumasa Suenaga wrote:
>>> PING:
>>>
>>> Have you checked this issue?
>>>
>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8175816/webrev.00/
>>>
>>>
>>> Yasumasa
>>>
>>>
>>> On 2017/09/11 22:47, Yasumasa Suenaga wrote:
>>>> Hi all,
>>>>
>>>> This review request is a part of [1].
>>>>
>>>>
>>>> JBS:
>>>>    https://bugs.openjdk.java.net/browse/JDK-8175816
>>>>
>>>> webrev:
>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8175816/webrev.00/
>>>>
>>>>
>>>> I cannot access JPRT. So I need a sponsor.
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> [1]
>>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html 
>>>>
>>>>



More information about the serviceability-dev mailing list