PING: RFR: 8175816: SA: HSDB: Compute Liveness results in java.lang.IndexOutOfBoundsException
serguei.spitsyn at oracle.com
serguei.spitsyn at oracle.com
Fri Sep 29 08:21:36 UTC 2017
Hi Yasumasa,
On 9/28/17 18:04, Yasumasa Suenaga wrote:
> Hi Serguei,
>
>> One minor comment:
>> Not all imports in the test are ordered correctly.
> I changed import order about jdk.test.lib in testcase:
>
> http://cr.openjdk.java.net/~ysuenaga/JDK-8175816/webrev.02/
>
> I will send a changeset to you if you will be a sponsor :-)
Ok, I'll push it.
No need to send a patch as you have it in your webrev.
Thanks,
Serguei
> Thanks,
>
> Yasumasa
>
>
> 2017-09-29 8:22 GMT+09:00 serguei.spitsyn at oracle.com
> <serguei.spitsyn at oracle.com>:
>> Hi Yasumasa,
>>
>> The fix looks good to me.
>> One minor comment:
>> Not all imports in the test are ordered correctly.
>>
>> Thanks,
>> Serguei
>>
>>
>>
>> On 9/23/17 05:13, Yasumasa Suenaga wrote:
>>> Hi Jini,
>>>
>>> I've added a test case for this in new webrev.
>>> This webrev is for consolidated jdk10/hs.
>>>
>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8175816/webrev.01/
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>>
>>>
>>> On 2017/09/22 15:12, Jini George wrote:
>>>> Hi Yasumasa,
>>>>
>>>> Your change looks good. But please do add in a test case for this.
>>>>
>>>> Thanks,
>>>> Jini (not a Reviewer).
>>>>
>>>> On 9/21/2017 4:18 AM, Yasumasa Suenaga wrote:
>>>>> PING:
>>>>>
>>>>> Have you checked this issue?
>>>>>
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8175816/webrev.00/
>>>>>
>>>>>
>>>>> Yasumasa
>>>>>
>>>>>
>>>>> On 2017/09/11 22:47, Yasumasa Suenaga wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> This review request is a part of [1].
>>>>>>
>>>>>>
>>>>>> JBS:
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8175816
>>>>>>
>>>>>> webrev:
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8175816/webrev.00/
>>>>>>
>>>>>>
>>>>>> I cannot access JPRT. So I need a sponsor.
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Yasumasa
>>>>>>
>>>>>>
>>>>>> [1]
>>>>>>
>>>>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html
>>>>>>
More information about the serviceability-dev
mailing list