[8u] RFR for backport of "JDK-8165736: Error message should be shown when JVMTI agent cannot be attached" to jdk8u-dev

[Shafi Ahmad]

Thank you David and Serguei. 

I have uploaded the webrev for my reference.
http://cr.openjdk.java.net/~shshahma/8165736/hotspot.01/

Regards,
Shafi

> -----Original Message-----
> From: Serguei Spitsyn
> Sent: Tuesday, April 03, 2018 12:03 AM
> To: David Holmes <david.holmes at oracle.com>; Shafi Ahmad
> <shafi.s.ahmad at oracle.com>; serviceability-dev at openjdk.java.net
> Cc: Yasumasa Suenaga <yasuenag at gmail.com>
> Subject: Re: [8u] RFR for backport of "JDK-8165736: Error message should be
> shown when JVMTI agent cannot be attached" to jdk8u-dev
> 
> Hi Shafi,
> 
> I agree with David.
> Consider it reviewed if you add the initialization of ebuf.
> 
> Thanks,
> Serguei
> 
> 
> On 3/31/18 00:24, David Holmes wrote:
> > Hi Shafi,
> >
> > On 29/03/2018 7:11 PM, Shafi Ahmad wrote:
> >> Hi,
> >>
> >> Please review the backport of ' JDK-8165736: Error message should be
> >> shown when JVMTI agent cannot be attached' to jdk8u-dev.
> >> Please note that this is not a clean backport because we can't not
> >> backport native jtreg tests as  infrastructure of naive jtreg test
> >> has been available since JDK 9.
> >
> > Ok.
> >
> >> webrev: http://cr.openjdk.java.net/~shshahma/8165736/
> >> jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8165736
> >> original patch pushed to jdk10:
> >> http://hg.openjdk.java.net/jdk/jdk/rev/bc1cffa26561
> >
> > src/share/vm/prims/jvmtiExport.cpp
> >
> > You missed the initalization of ebuf:
> >
> > +  char ebuf[1024] = {0};
> >
> > Otherwise the functional backport seems okay.
> >
> > Thanks,
> > David
> >
> >> Test:  Run jprt -testset hotspot, -testset core
> >>
> >> Regards,
> >> Shafi
> >>
>