RFR: 8200195 : serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java crashes with "assert(thread->thread_state() == _thread_in_native) failed: coming from wrong thread state"

Chris Plummer chris.plummer at oracle.com
Mon Apr 9 21:28:49 UTC 2018


Hi Alex,

I'd suggest renaming javaEnv to jni_env to be consistent. Not sure why 
javaEnv was chosen in the original implementation. Otherwise the changes 
look good.

thanks,

Chris

On 4/9/18 2:13 PM, Alex Menkov wrote:
> Hi all,
>
> Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8200195
> webrev: http://cr.openjdk.java.net/~amenkov/field_access_graal/webrev/
>
> The problem with the test is it uses cached JNIEnv value instead using 
> a value passed to the callbacks. JNIEnv is valid only for the current 
> thread.
>
> --alex




More information about the serviceability-dev mailing list