RFR: 8196325: GarbageCollectionNotificationInfo has same information for before and after

[sangheon.kim]

Hi Mandy,

On 04/18/2018 02:20 AM, mandy chung wrote:
> Hi Sangheon,
>
>
> On 4/18/18 12:41 PM, sangheon.kim wrote:
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8196325
>> webrev: http://cr.openjdk.java.net/~sangheki/8196325/webrev.0/
>
> This is indeed a regression.  GcInfoBuilder depends on the order of 
> the pool name array.
>
> The change looks okay.  I would suggest to use stream in the new 
> getAllMemoryPoolNames() like this:
>
>     public static String[] getAllMemoryPoolNames() {
>         return Arrays.stream(MemoryImpl.getMemoryPools())
>                       .map(MemoryPoolMXBean::getName)
>                      .toArray(String[]::new);
>     }
Done.

>
>> Testing: 
>> jdk-tier1,jdk-tier2,jdk-tier3,hs-tier1,hs-tier2,builds-tier1, 
>> jdk_management, jdk_jmx
>>
>
> These test groups are good.
Okay.

Webrev:
http://cr.openjdk.java.net/~sangheki/8196325/webrev.1 (full)
http://cr.openjdk.java.net/~sangheki/8196325/webrev.1_to_0/ (inc)

Sangheon


>
> Mandy
>
>> Thanks,
>> Sangheon
>