RFR: 8202417: [TESTBUG] Broken hard-coded dependency in serviceability/sa/ClhsdbJhisto.java

Alan Bateman Alan.Bateman at oracle.com
Mon Apr 30 09:33:34 UTC 2018



On 30/04/2018 10:30, Claes Redestad wrote:
> Hi,
>
> ClhsdbJhisto has a hard-coded dependency on an 
> ImmutableCollections$SetN$1 appearing in the jhisto output, which is 
> fragile and sometimes break after JDK-8201650. I suggest removing it 
> from the test:
>
> diff -r 96d4658eb7f2 
> test/hotspot/jtreg/serviceability/sa/ClhsdbJhisto.java
> --- a/test/hotspot/jtreg/serviceability/sa/ClhsdbJhisto.java  Mon Apr 
> 30 09:15:44 2018 +0200
> +++ b/test/hotspot/jtreg/serviceability/sa/ClhsdbJhisto.java  Mon Apr 
> 30 11:28:08 2018 +0200
> @@ -62,8 +62,7 @@
>                      "java.nio.HeapByteBuffer",
>                      "java.net.URI",
>                      "LingeredAppWithInterface",
> -                    "ParselTongue",
> -                    "ImmutableCollections$SetN$1"));
> +                    "ParselTongue"));
>
>              test.run(theApp.getPid(), cmds, expStrMap, null);
>          } catch (Exception ex) {
This looks okay, at least as a short term fix. I agree it's way too 
fragile to depend on such classes and needs to stick to classes that are 
closer to the area that it tests.

-Alan


More information about the serviceability-dev mailing list