RFR (S) 8203356: VM Object Allocation Collector can infinite recurse

[Hohensee, Paul]

lgtm.

Paul

From: serviceability-dev <serviceability-dev-bounces at openjdk.java.net> on behalf of JC Beyler <jcbeyler at google.com>
Date: Wednesday, August 22, 2018 at 4:21 PM
To: "serviceability-dev at openjdk.java.net" <serviceability-dev at openjdk.java.net>
Subject: Re: RFR (S) 8203356: VM Object Allocation Collector can infinite recurse

Hi all,

Would anyone want to look at this change? It helps fix a minor bug if someone provokes a VM allocation during a VM Allocation Event.

Webrev: http://cr.openjdk.java.net/~jcbeyler/8203356/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8203356

Thanks!
Jc

On Thu, Aug 2, 2018 at 12:46 PM JC Beyler <jcbeyler at google.com<mailto:jcbeyler at google.com>> wrote:
Hi all,

(Renaming the thread that did not have the RFR in front of the subject, I apologize)

Could someone review this change:

Webrev: http://cr.openjdk.java.net/~jcbeyler/8203356/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8203356

Basically, if during a callback from a VMObjectAlloc event, the user provokes a clone, the code would send a new callback and you can recurse infinitely.

I added a test that fails without the fix and passes now.

Thanks,
Jc


--

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180823/ca07a303/attachment.html>