RFR(XXS) : 8210108 : sun/tools/jstatd test build failures after JDK-8210022
JC Beyler
jcbeyler at google.com
Tue Aug 28 20:30:07 UTC 2018
Hi Igor,
Looks good to me,
Jc
On Tue, Aug 28, 2018 at 1:19 PM Mikael Vidstedt <mikael.vidstedt at oracle.com>
wrote:
>
> Looks good, thanks for fixing!
>
> Cheers,
> Mikael
>
> > On Aug 28, 2018, at 11:57 AM, Igor Ignatyev <igor.ignatyev at oracle.com>
> wrote:
> >
> > http://cr.openjdk.java.net/~iignatyev//8210108/webrev.00/index.html
> >> 3 lines changed: 1 ins; 1 del; 1 mod;
> >
> >
> > Hi all,
> >
> > could you please review this small and trivial follow-up fix?
> >
> > unfortunately, test/jdk/sun/tools/jstatd/JstatdTest now uses two
> different OutputAnalyzer classes, jdk.test.lib.process.OutputAnalyzer which
> it gets from jdk.test.lib.process.ProcessThread, and
> jdk.testlibrary.OutputAnalyzer from jdk.testlibrary.ProcessTools. as
> JstatdTest uses j.t.OutputAnalyzer more often, the fix restores import
> statement and uses FQDN where j.t.l.process.OutputAnalyzer is used.
> >
> > // we will get rid of this FQDN, as soon as jdk.testlibrary.ProcessTools
> is "merged" w/ jdk.t.l.process.ProcessTools, which is tracked by 8210112.
> >
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8210108
> > webrev:
> http://cr.openjdk.java.net/~iignatyev//8210108/webrev.00/index.html
> > testing: sun/tools/jstatd tests
> >
> > Thanks,
> > -- Igor
>
>
--
Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180828/97742701/attachment.html>
More information about the serviceability-dev
mailing list