RFR (XS) 8208186: SetHeapSamplingInterval handles 1 explicitly

Alex Menkov alexey.menkov at oracle.com
Tue Aug 28 23:30:33 UTC 2018


Hi Jc,

Looks good to me.

--alex

On 08/28/2018 14:43, JC Beyler wrote:
> Hi all,
> 
> Here is another extra small webrev for review where the code handles the 
> interval 1 differently but this was an artifact of the original 
> implementation. We could remove the test altogether (the rest of the 
> code makes the 0 "sample everything" work by side-effect) but for 
> readability/maintainance, it is best to explicitly test for and return 0.
> 
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8208186/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejcbeyler/8208186/webrev.00/>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8208186
> 
> Thanks,
> Jc


More information about the serviceability-dev mailing list