[PATCH] JDK-8025886: Replace [[ and == bash extensions in tests

[Sergei Ustimenko]

Martin,

>you probably won't be able to build openjdk on a system without bash

Most certainly not, it appears

I really wonder now if there's any policy/rule of thumb to not to use
/bin/sh.
I don't feel really comfortable if there would be such a policy.

I've checked build docs and it seems that troubleshooting section could be
a bit enhanced, though I guess that is given, that user knows how to
change a /bin/sh symlink. So I don't know if it worth to do this.

Regards,
Sergei

On Mon, 10 Dec 2018 at 22:27, Martin Buchholz <martinrb at google.com> wrote:

> I don't know if there's an official policy on how ultra-portable tests are
> supposed to be.  In practice, you probably won't be able to build openjdk
> on a system without bash.
>
> On Mon, Dec 10, 2018 at 1:12 PM Sergei Ustimenko <merkel05 at gmail.com>
> wrote:
>
>> Hi Martin,
>>
>> That sounds good!
>>
>> I've counted all the sh-shebangs and it appears that
>> there are at least 66 of them inside the test/ directory,
>> where only 12 bashes.
>>
>> I've also ran the search  in order to identify all the
>> occurrences that use either [[ or == and found only
>> three of them that use "==". That one for example:
>>
>> http://hg.openjdk.java.net/jdk/sandbox/file/f94276ccc9fc/test/hotspot/jtreg/vmTestbase/jit/tiered/tieredTest.sh#l63
>> of course `dash` reports failure in that case.
>>
>> So I'm quite hesitant in that case and not really sure
>> what to do. I haven't also found any existent JBS ticket
>> for such /bin/sh => /bin/bash a replacement.
>>
>> So any advise in this case would be appreciated!
>>
>> Regards,
>> Sergei
>>
>> On Mon, 10 Dec 2018 at 18:32, Martin Buchholz <martinrb at google.com>
>> wrote:
>>
>>> I would not try to remove all bash-isms from openjdk. Instead I would
>>> find instances of /bin/sh that need to be changed to /bin/bash.
>>>
>>> (Ubuntu's use of /bin/sh -> /bin/dash is technically correct, but caused
>>> much suffering
>>> https://bugs.launchpad.net/ubuntu/+source/dash/+bug/61463
>>> )
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181210/a4061a1c/attachment.html>