RFR (L) 8215160: Normalize spaces for remaining vmTestbase tests

Alex Menkov alexey.menkov at oracle.com
Mon Dec 10 22:28:55 UTC 2018


+1

One minor request.
Could you please fix
nsk/jvmti/NativeMethodBind/nativemethbind002/nativemethbind002.cpp
replacing

if (!(methNam == NULL))
and
if (!(methSig == NULL))

with
if (methNam != NULL)
and
if (methSig != NULL)

No need for new round of the review.

--alex


On 12/10/2018 13:54, serguei.spitsyn at oracle.com wrote:
> Hi Jc,
> 
> LGTM
> 
> Thank you for the re-post!
> Serguei
> 
> 
> On 12/10/18 13:46, JC Beyler wrote:
>> Hi all,
>>
>> Let's try this again; my apologies for the spam.
>>
>> Could I get a review that normalizes spaces around comparisons and the 
>> ternary operator? This is the second of two webrevs to handle this.
>>
>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8215160/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Ejcbeyler/8215160/webrev.00/>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8215160
>>
>> Thanks,
>> Jc
>>
> 


More information about the serviceability-dev mailing list