[8u] RFR: 8059038: Create new launcher for SA tools

Severin Gehwolf sgehwolf at redhat.com
Wed Dec 12 14:09:23 UTC 2018


Hi,

Can I get a review of this small 8u enhancement, please? It adds two
new launchers for the serviceability agent, one CLI version and one GUI
version:

$ <image>/bin/clhsdb
$ <image>/bin/hsdb

The enhancement request has been approved here:
http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-December/008257.html

During that discussion it has been suggested to use separate launchers
for GUI and CLI. So this is the revised two-launcher-approach:
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8059038/02/
bug: https://bugs.openjdk.java.net/browse/JDK-8059038

Note: The initial version of this patch[1] had one launcher "jhsdb"
with sub-commands "hsdb" and "clhsdb" delegating to the old launcher
classes.

The patch has two simple tests verifying that the launchers work.
Thoughts?

Thanks,
Severin

[1] http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8059038/01/



More information about the serviceability-dev mailing list