RFR: JDK-8211923- [Testbug] serviceability/sa/ClhsdbFindPC.java ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1

[JC Beyler]

Hi Sharath,

It looks like this bug is a potential duplicate of :
https://bugs.openjdk.java.net/browse/JDK-8196969
and
https://bugs.openjdk.java.net/browse/JDK-8145741

Should we not wait until the underlying bug is fixed before fixing this?
Although I believe that those bugs would still show up with your fix here
and maybe getting the interpreter first would be good information to have.
Since the test runs the application and tries to attach to it, I don't see
anything wrong with trying to modify the order of execution though and
getting a good messaged runtime exception instead of a more obscure index
out of bounds is a step in the right direction in my opinion.

So LGTM,
Jc

On Wed, Dec 12, 2018 at 10:43 PM Sharath Ballal <sharath.ballal at oracle.com>
wrote:

> Hi,
>
> Pls review the test fix in serviceability/sa/ClhsdbFindPC.java
>
> Jira: https://bugs.openjdk.java.net/browse/JDK-8211923
>
> Webrev: http://cr.openjdk.java.net/~sballal/8211923/webrev.00/
>
>
>
> I have done the following modifications to the testcase:
> 1. If jstack output does not contain "LingeredApp.main", fail the test.
> 2. The test is testing both -Xcomp and -Xint options. I have changed the
> order of the test and made -Xint first. Currently the failure is in -Xcomp.
> Changing the order will tell us (in future failures) if the interpretted
> mode passed or not.
>
>
>
> SA tests passed in Mach5 runs.
>
>
>
> Thanks,
>
> Sharath
>
>
>
>
>


-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181213/e9983701/attachment.html>