RFR: [XS] 8215411: some GetByteArrayElements calls miss corresponding Release

[JC Beyler]

Hi Matthias,

Your webrev looks good to me (not a reviewer though ;-)). I saw a few
things about the isCopy updates but that is out of scope of this webrev,
I'll be creating a separate one in a bit :-)

Thanks,
Jc

On Mon, Dec 17, 2018 at 1:00 AM Baesken, Matthias <matthias.baesken at sap.com>
wrote:

> Hello, please review the following change.
> I noticed that we miss at some places (for example in case of early
> returns)
> where GetByteArrayElements is used,  the corresponding
> ReleaseByteArrayElements  call.
>
> In VirtualMachineImpl.c  I also removed a check for isCopy (is the
> returned byte array a copy ?)
> because from what I read at
>
>
> https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/functions.html
>
> the ReleaseByteArrayElements  routine should always be called.
>
>
> bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8215411
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8215411.0/
>
>
> Thanks, Matthias
>


-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181217/d5b26dcc/attachment.html>