RFR (XS) 8215495: Always set isCopy

David Holmes david.holmes at oracle.com
Mon Dec 17 21:29:39 UTC 2018


Hi Jc,

On 18/12/2018 3:42 am, JC Beyler wrote:
> Hi all,
> 
> Could I get a review for this webrev:
> 
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8215495/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8215495

isCopy only has to be set if the method executes successfully

"If isCopy is not NULL, then *isCopy is set to JNI_TRUE if a copy is 
made; or it is set to JNI_FALSE if no copy is made."

You can only make (or not) a copy if the operation actually succeeds. So 
before checking isCopy the caller must check for NULL and/or a pending 
exception.

I see no bug here.

David
-----

> Thanks,
> Jc


More information about the serviceability-dev mailing list