[PATCH] 8214535: Extend JMap to support parallel and incremental heap scanning

[JC Beyler]

Hi Lin,

Done:

>
> 1.     Add dump to file support for jmap –histo
>
https://bugs.openjdk.java.net/browse/JDK-8215622


> 2.     Add incremental dump for jmap –histo
>
 https://bugs.openjdk.java.net/browse/JDK-8215623

> 3.     Add parallel heap iteration for jmap –histo.
>
https://bugs.openjdk.java.net/browse/JDK-8215624


> Is it reasonable ?
>

Sounded reasonable to me :-)
Jc


> Thanks!
>
>
>
> BRs,
>
> Lin
>
> *From:* JC Beyler [mailto:jcbeyler at google.com]
> *Sent:* Wednesday, December 19, 2018 12:56 AM
> *To:* 臧琳 <zanglin5 at jd.com>
> *Cc:* serviceability-dev at openjdk.java.net
> *Subject:* Re: [PATCH] 8214535: Extend JMap to support parallel and
> incremental heap scanning
>
>
>
> Hi Lin,
>
>
>
> Would it not be easier to make 3 different JBS items that are all
> enhancements? Or perhaps 3 subtasks to the original JDK-8214535? Then you
> could send out a request for review for the first two and we can talk about
> the third.
>
>
>
> I think all three parts can be considered separately (and it seems you do
> too).
>
>
>
> Thanks,
>
> Jc
>
>
>
> On Tue, Dec 18, 2018 at 12:58 AM 臧琳 <zanglin5 at jd.com> wrote:
>
> Hi All,
>
>     I am preparing the patch for
> https://bugs.openjdk.java.net/browse/JDK-8214535, and want to get your
> suggestions.
>
>
>
>     To make the patch easier to review. I plan to make 3 patches as
> following:
>
>     1. one patch for enabling file dump of "jmap -histo".(
> http://cr.openjdk.java.net/~xiaofeya/JDK-8214535/file_dump/webrev.00/webrev/
> )
>
>     2. one patch for incremental dump intermediate data to file of "jmap
> -histo".(
> http://cr.openjdk.java.net/~xiaofeya/JDK-8214535/incremental/webrev.00/)
>
>     3. one patch for parallel iterating heap of "jmap -histo". (WIP)
>
>
>
>     And the patches for item 1 & 2 are ready. patch for 3 is WIP.
>
>     May I ask your help to review these patches?
>
>     Thanks.
>
>
>
> BRs,
>
> Lin
>
>
>
>
> --
>
>
>
> Thanks,
>
> Jc
>


-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181218/0254ad87/attachment.html>