RFR: JDK-8215568: Refactor SA clhsdb tests to use ClhsdbLauncher

[JC Beyler]

Hi Jini,

I saw this potential issue with one of the test conversions:
http://cr.openjdk.java.net/~jgeorge/8215568/webrev.00/test/hotspot/jtreg/serviceability/sa/TestPrintMdo.java.udiff.html
   - It seems like there is a missing "unexpected" strings check here no?
      - The original test was doing
-
-                if (line.contains("missing reason for ")) {
-                    unexpected = new RuntimeException("Unexpected msg:
missing reason for ");
-                    break;
-                }

whereas the new test is not seemingly (though
http://cr.openjdk.java.net/~jgeorge/8215568/webrev.00/test/hotspot/jtreg/serviceability/sa/TestClhsdbJstackLock.java.udiff.html
does do it so I think this is an oversight?).

   - Also interesting is that the original test was trying to find one of X:
-                if (line.contains("VirtualCallData")  ||
-                    line.contains("CounterData")      ||
-                    line.contains("ReceiverTypeData")) {
-                    knownProfileDataTypeFound = true;
-                }

whereas you are now wanting to find all of them. Is that normal/wanted?

The rest looked good to me, though I wish there were a way to not have to
change all the strings to be regex friendly but I fail to see how to do
that without writing a runCmdWithoutRegexMatcher, which seems overkill :-)
Jc

On Tue, Dec 18, 2018 at 8:55 PM Jini George <jini.george at oracle.com> wrote:

> Hello!
>
> Requesting reviews for:
>
> http://cr.openjdk.java.net/~jgeorge/8215568/webrev.00/
>
> BugID: https://bugs.openjdk.java.net/browse/JDK-8215568
>
> No new failures with the SA tests (hs-tiers 1-5) with these changes. The
> changes here include:
>
> * Refactoring the SA tests which test clhsdb commands to use
> ClhsdbLauncher for uniformity and ease of maintainence.
> * Testing for regular expressions with shouldMatch rather than
> shouldContain.
> * Minor cleanups.
>
> Thank you,
> Jini.
>
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181219/28f5b7d8/attachment-0001.html>