8161605 : The '!UseSharedSpaces' check is not need in JvmtiManageCapabilities::recompute_always_capabilities

[serguei.spitsyn at oracle.com]

One more attempt to send it with the correct to-list...
Sorry for the noise.


Hi Alex,

It looks good in general.
A couple of comments on the test.

We had a convention to avoid having test sub-folders with bug numbers.
Could you, please, rename it to some symbolic name?

Also we need the test to fail in the native agent when an error is 
reported with the reportError().

It'd be great if some CDS/AppCDS experts from the Runtime team look at 
the fix and test
so I've included Jiangli and Misha into the to-list.

Thanks,
Serguei


On 1/25/18 16:11, Alex Menkov wrote:
> Hi all,
>
> Please take a look at a fix for
> JDK-8161605 : The '!UseSharedSpaces' check is not need in 
> JvmtiManageCapabilities::recompute_always_capabilities
>
> The fix moves can_generate_all_class_hook_events capability from 
> "onload_capabilities" to "always_capabilities" and cleans up 
> recompute_always_capabilities method.
>
> jira: https://bugs.openjdk.java.net/browse/JDK-8161605
> webrev: 
> http://cr.openjdk.java.net/~amenkov/can_generate_class_hook/webrev/
>
> --alex