RFR 8196308: Update AllLineLocations & ClassesByName to use TestScaffold instead of JDIScaffold
serguei.spitsyn at oracle.com
serguei.spitsyn at oracle.com
Mon Feb 5 22:33:24 UTC 2018
Looks good.
Thank you for the update!
Thanks,
Serguei
On 2/5/18 14:07, Paru Somashekar wrote:
> Thanks Serguei, I have updated the review.
>
> thanks,
> Paru.
>
> On 2/5/18, 12:29 PM, serguei.spitsyn at oracle.com wrote:
>> Hi Paru,
>>
>> 30 * @run build JDIScaffold VMConnection
>> 31 * @run build JDIScaffold VMConnection
>>
>> The JDIScaffold has to be replaced with the TestScaffold in both files.
>>
>> Otherwise, it looks good to me.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 2/5/18 11:17, Paru Somashekar wrote:
>>> Hi,
>>>
>>> Please review the fix for JDK-8196308
>>>
>>> Bug : https://bugs.openjdk.java.net/browse/JDK-8196308
>>> Webrev : http://cr.openjdk.java.net/~psomashe/8196308/webrev/
>>> <http://cr.openjdk.java.net/%7Epsomashe/8196308/webrev/>
>>>
>>> The updated tests ran successfully with Mach5.
>>>
>>> thanks,
>>> Paru.
>>
>
More information about the serviceability-dev
mailing list