JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

[gary.adams at oracle.com]

A fresh webrev rebased with latest jdk/jdk repos:
  http://cr.openjdk.java.net/~gadams/8080990/webrev.03/index.html

If there are no more comments, I'll check in locally with these reviewers
   clanger,chegar,erikj

and cut patches on Thurs AM.


On 2/5/18 2:15 PM, Gary Adams wrote:
> One more to fix to cover the remaining test failures I was seeing.
>
> Previously, using inet_addr, there was a single -1 return that needed 
> to be checked.
> Now that we're using inet_pton, there is a -1 and a 0 error return to 
> be considered.
>
> My preference would be to leave the dbgSysInetAddr name unchanged and 
> have the low level
> check for inet_pton errors to simply return the -1 that was previously 
> checked.
>
> This specific issue is about the deprecation of library functions on 
> windows. I'd recommend not
> upgrading the other platforms at this time until a complete update is 
> done for ipv6 support.
>
> I'll post a new webrev when I've retested using the updated inet_pton 
> error checking.
>
> ...
>> Hi Gary,
>>
>>
>> >/Here's a revised webrev />//>/http://cr.openjdk.java.net/~gadams/8080990/webrev.01/index.html 
>> <http://cr.openjdk.java.net/%7Egadams/8080990/webrev.01/index.html> />//>/Still testing ... />//>/Using shutdown() fixed problems reported by the />/java/nio/channelSocketChannel tests. /
>> The fix looks good. I would think we should rename dbgsysInetAddr to dbgsysPToN and use inet_pton also for the Unix/Linux platforms. It would be the better choice there as well, though we still only support IPv4 in libdt_socket.
>>
>> >//>/I also noticed prior use of getaddrinfo for "localhost" was not calling />/freeaddrinfo. /
>> Thanks for spotting/fixing that.
>>
>> Best regards
>> Christoph
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180207/e01d5e1f/attachment.html>