RFR: 8041626: [Event Request] Shutdown reason
Roger Riggs
Roger.Riggs at Oracle.com
Tue Feb 13 15:17:54 UTC 2018
Hi Robin,
It looks like the status argument to BeforeHalt is discarded in
JVM_BeforeHalt
and is not inserted into the event.
That suggests it should be removed all the way back to Shutdown.beforeHalt.
Roger
On 2/13/2018 9:59 AM, Robin Westberg wrote:
> Hi Alan,
>
>> On 12 Feb 2018, at 09:02, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>>
>>
>>
>> On 12/02/2018 07:07, David Holmes wrote:
>>>> Okay, I’ve removed the code related to the status field, certainly makes the change a bit less intrusive.
>>>>
>>>> Updated webrev: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.01/
>>>> Incremental: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.00-01/
>>> This looks much cleaner/neater to me - thanks.
>>>
>> The updates to Runtime/Shutdown seems okay.
> Thanks for reviewing!
>
> Best regards,
> Robin
>
>> -Alan
More information about the serviceability-dev
mailing list