RFR JDK-8198253: ThreadInfo.from(CompositeData) assigning fields incorrectly in JDK 9

Jeremy Manson jeremymanson at google.com
Fri Feb 16 00:46:56 UTC 2018


Hi folks,

Been a long time!  I'd like someone to do a code review.  This is in code I
wrote a few years ago, and got wrong.  At the time, David Holmes, Staffan
Larsen, and Mandy Chung reviewed it.  It does mean that people using
ThreadInfo.from(CompositeData) may be getting the wrong values out for
ThreadInfo, so it is definitely worth fixing.

The patch below fixes the bug, but is a pretty questionable approach.
Better approaches happily considered.

Patch:
http://cr.openjdk.java.net/~jmanson/8198253/webrev.00/

Bug:
https://bugs.openjdk.java.net/browse/JDK-8198253

Thanks!

Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180215/668f408c/attachment.html>


More information about the serviceability-dev mailing list