RFR JDK-8198253: ThreadInfo.from(CompositeData) assigning fields incorrectly in JDK 9

[Jeremy Manson]

On Thu, Feb 15, 2018 at 6:40 PM, David Holmes <david.holmes at oracle.com>
wrote:

> On 16/02/2018 11:12 AM, Jeremy Manson wrote:
>
>> Previous bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-6588467
>>
>> And the review thread:
>>
>> http://mail.openjdk.java.net/pipermail/serviceability-dev/20
>> 15-January/016356.html
>>
>> I don't think the bug would have been obvious to a reviewer (or, indeed,
>> the author of the patch!), because we would have had to think about how
>> ticd.isCurrentVersion worked, and noticed the fact that some of the fields
>> are optional.
>>
>
> I misunderstood the connection to the old bug and review. This is a
> pre-existing issue that wasn't noticed last time this code was updated -
> right?
>

Sort of.  The uses of isCurrentVersion() didn't happen to need to exclude
optional values before I made my changes.  It falls under the category of
unstated assumptions.  The method could have been called
"isCurrentVersionAndDoesntIgnoreOptionalValues".  :)

Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180215/eb059b6f/attachment.html>