RFR : JDK-8175542 - JMX: Not enough JDP packets received

[Amit Sapre]

Hello,

 

Ping. Can somebody review this code changes ?

 

Thanks,

Amit

 

From: Amit Sapre 
Sent: Wednesday, January 03, 2018 5:54 PM
To: Harsha wardhana B; serviceability-dev at openjdk.java.net
Subject: RE: RFR : JDK-8175542 - JMX: Not enough JDP packets received

 

Thanks Harsha for the inputs.

 

I made changes in this webrev : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8175542/webrev.01/

 

Thanks,

Amit

 

From: Harsha Wardhana B 
Sent: Wednesday, December 13, 2017 5:32 PM
To: HYPERLINK "mailto:serviceability-dev at openjdk.java.net"serviceability-dev at openjdk.java.net
Subject: Re: RFR : JDK-8175542 - JMX: Not enough JDP packets received

 

Hi Amit,

Increasing the timeout 'TIME_OUT_FACTOR' will increase both socket and test-case timeout. The test passed as can be seen from the log, but because of the race-condition: hasTestLivedLongEnough() checked before shouldContinue(), the test was declared failed because of time-out.

One possible fix would be to change line 80 to,

                if (shouldContinue() && hasTestLivedLongEnough())

Thanks

Harsha

 

On Wednesday 13 December 2017 11:03 AM, Amit Sapre wrote:

Hello,

 

Please review the timeout fix for this bug.

 

Bug ID : https://bugs.openjdk.java.net/browse/JDK-8175542 

Webrev : HYPERLINK "http://cr.openjdk.java.net/%7Easapre/webrev/2017/JDK-8175542/webrev.00/"http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8175542/webrev.00/

 

Thanks,

Amit

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180110/4e01fcaa/attachment.html>