RFR : JDK-8175542 - JMX: Not enough JDP packets received

[Harsha Wardhana B]

Hi Amit,

Looks okay to me.

Thanks

Harsha


On Wednesday 03 January 2018 05:54 PM, Amit Sapre wrote:
>
> Thanks Harsha for the inputs.
>
> I made changes in this webrev : 
> http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8175542/webrev.01/ 
> <http://cr.openjdk.java.net/%7Easapre/webrev/2018/JDK-8175542/webrev.01/>
>
> Thanks,
>
> Amit
>
> *From:*Harsha Wardhana B
> *Sent:* Wednesday, December 13, 2017 5:32 PM
> *To:* serviceability-dev at openjdk.java.net
> *Subject:* Re: RFR : JDK-8175542 - JMX: Not enough JDP packets received
>
> Hi Amit,
>
> Increasing the timeout 'TIME_OUT_FACTOR' will increase both socket and 
> test-case timeout. The test passed as can be seen from the log, but 
> because of the race-condition: hasTestLivedLongEnough() checked before 
> shouldContinue(), the test was declared failed because of time-out.
>
> One possible fix would be to change line 80 to,
>
>                 if (shouldContinue() && hasTestLivedLongEnough())
>
> Thanks
>
> Harsha
>
> On Wednesday 13 December 2017 11:03 AM, Amit Sapre wrote:
>
>     Hello,
>
>     Please review the timeout fix for this bug.
>
>     Bug ID : https://bugs.openjdk.java.net/browse/JDK-8175542
>
>     Webrev :
>     http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8175542/webrev.00/
>     <http://cr.openjdk.java.net/%7Easapre/webrev/2017/JDK-8175542/webrev.00/>
>
>     Thanks,
>
>     Amit
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180111/87d72d37/attachment-0001.html>