JDK-8187447: 2081 doc issues in jvmti.html

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Sat Jan 13 01:06:29 UTC 2018


Hi Alex,

The fix is pretty impressive.
Thank you for taking care about all these html issues!

I'd like to ask about one thing.
The renaming of the <p> element into <sep> in the jvmti.xml is not
that necessary but is very intrusive as it impacts too many places.
Could you, please, keep these elements as they are for now?

Thanks,
Serguei


On 1/11/18 17:21, Alex Menkov wrote:
> Hi,
>
> Please review a fix for doc issue.
>
> jira: https://bugs.openjdk.java.net/browse/JDK-8187447
> webrev: http://cr.openjdk.java.net/~amenkov/8187447/webrev/
>
> old jvmti.html: http://cr.openjdk.java.net/~amenkov/8187447/jvmti_0.html
> new jvmti.html: http://cr.openjdk.java.net/~amenkov/8187447/jvmti.html
>
> specdiff reports no changes: 
> http://cr.openjdk.java.net/~amenkov/8187447/specdiff/diff.html
>
> The fix:
> - converts jvmti.html from HTML4 to HTML5;
> - fixes all errors and almost all warnings reported by tidy and W3C 
> HTML Validator:
>   - empty <p>;
>   - unsupported attributes (align, border, width, cellpadding, 
> cellspacing, noshade, size, bgcolor, type);
>   - <dl> without nested <dt>;
>   - <a> with "name" attribute;
>   - table with column with no cells beginning in it (all cells have 
> colspan=2);
> - adds "lang" attribute for <html> (accessibility issue).
>
> The only remaining warning (reported by W3C HTML Validator) is
>   Warning: Documents should not use about:legacy-compat, except if 
> generated by legacy systems that can't output the standard <!DOCTYPE 
> html> doctype.
> This is expected as the DOCTYPE legacy string 
> (http://w3c.github.io/html/single-page.html#doctype-legacy-string) was 
> added to HTML5 standard to handle issue with XLST which cannot produce 
> standard doctype.
>
> --alex



More information about the serviceability-dev mailing list