RFR: 8194143: remove unneeded casts in LocationImpl and MirrorImpl classes
Egor Ushakov
egor.ushakov at jetbrains.com
Wed Jan 17 17:36:50 UTC 2018
Got it, will do!
BTW who are the reviewers? You and David?
On 17-Jan-18 20:34, serguei.spitsyn at oracle.com wrote:
> On 1/17/18 09:26, serguei.spitsyn at oracle.com wrote:
>> Hi Egor and David,
>>
>> Both webrevs below are from Daniil Titov on the JVMTI bug: JDK-8153629.
>
> Sorry, it is not fully correct.
> The first is the old link points to the jdk 10 related webrev with an
> uncommitted patch and 2017 copyright comments.
>
>
>> Also, I expect new webrev is based on the JDK 11 jdk/hs repository
>> and with 2018 copyright comments updated.
>
> Also need this patch committed with reviewers listed.
>
>
> Thanks,
> Serguei
>
>
>> Thanks,
>> Serguei
>>
>>
>> On 1/17/18 02:24, David Holmes wrote:
>>> Hi Egor,
>>>
>>> On 17/01/2018 7:15 PM, Egor Ushakov wrote:
>>>> Hello,
>>>>
>>>> Please review and push the fix.
>>>> This is a formal letter after the discussion on the alias.
>>>>
>>>> Bug:https://bugs.openjdk.java.net/browse/JDK-8194143
>>>> Webrev:http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix/
>>>
>>> The underlying link actually pointed to:
>>>
>>> http://cr.openjdk.java.net/%7Edtitov/8153629/webrev.00
>>>
>>> :)
>>>
>>> Real webrev looks fine.
>>>
>>> Thanks,
>>> David
>>>
>>>> --
>>>> Egor Ushakov
>>>> Software Developer
>>>> JetBrains
>>>> http://www.jetbrains.com
>>>> The Drive to Develop
>>>>
>>
>
--
Egor Ushakov
Software Developer
JetBrains
http://www.jetbrains.com
The Drive to Develop
More information about the serviceability-dev
mailing list