RFR: 8194143: remove unneeded casts in LocationImpl and MirrorImpl classes

David Holmes david.holmes at oracle.com
Wed Jan 17 22:36:20 UTC 2018


On 18/01/2018 3:32 AM, Egor Ushakov wrote:
> Is the link http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix 
> broken? for me it works well.

To clarify ... your earlier email was in multi-part-mime format 
including a plain text and html part. The html version has:

Bug: <a class="moz-txt-link-freetext" 
href="https://bugs.openjdk.java.net/browse/JDK-8153629">https://bugs.openjdk.java.net/browse/JDK-8194143</a>
Webrev: <a class="moz-txt-link-freetext" 
href="http://cr.openjdk.java.net/%7Edtitov/8153629/webrev.00">http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix/</a>

where as you can see the actual target for the links is not the same as 
the text describing the links.

David

> attaching the patch just in case.
> It was created on jdk10, do I need to recreate it based on jdk11 with 
> the 2018 copyrights?
> 
> On 17-Jan-18 20:26, serguei.spitsyn at oracle.com wrote:
>> Hi Egor and David,
>>
>> Both webrevs below are from Daniil Titov on the JVMTI bug: JDK-8153629.
>> Also, I expect new webrev is based on the JDK 11 jdk/hs repository and 
>> with 2018 copyright comments updated.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 1/17/18 02:24, David Holmes wrote:
>>> Hi Egor,
>>>
>>> On 17/01/2018 7:15 PM, Egor Ushakov wrote:
>>>> Hello,
>>>>
>>>> Please review and push the fix.
>>>> This is a formal letter after the discussion on the alias.
>>>>
>>>> Bug:https://bugs.openjdk.java.net/browse/JDK-8194143
>>>> Webrev:http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix/
>>>
>>> The underlying link actually pointed to:
>>>
>>> http://cr.openjdk.java.net/%7Edtitov/8153629/webrev.00
>>>
>>> :)
>>>
>>> Real webrev looks fine.
>>>
>>> Thanks,
>>> David
>>>
>>>> -- 
>>>> Egor Ushakov
>>>> Software Developer
>>>> JetBrains
>>>> http://www.jetbrains.com
>>>> The Drive to Develop
>>>>
>>
> 


More information about the serviceability-dev mailing list