PING: RFR: 8194249: SA: G1HeapRegionTable#getByAddress() returns incorrect HeapRegion
Thomas Schatzl
thomas.schatzl at oracle.com
Tue Jan 30 10:06:14 UTC 2018
Hi,
On Tue, 2018-01-30 at 07:00 +1000, David Holmes wrote:
> Added in hotspot-gc-dev. Although this is in the SA it is about the
> SA interaction with G1 and so likely needs someone familiar with G1
> to review it.
>
> David
>
> On 28/01/2018 10:41 PM, Yasumasa Suenaga wrote:
> > PING: Could you review it?
> >
> > > > http://cr.openjdk.java.net/~ysuenaga/JDK-8194249/webrev.01/
> >
> > This webrev has been reviewed by Jini.
> > I need a Reviewer and sponsor.
looks good to me - however there is another (pre-existing) bug: the
shift in that code should be a logical shift, not an arithmetic shift.
I.e. ">>" instead of ">>>".
I will run the patch through testing and report back in a few hours.
Should be okay.
Thanks,
Thomas
More information about the serviceability-dev
mailing list