8206145 : dbgsysSocketClose - do not restart close if errno is EINTR [linux] - was : RE: RFR : 8205959 : Do not restart close if errno is EINTR

Baesken, Matthias matthias.baesken at sap.com
Wed Jul 4 13:00:38 UTC 2018


Ok, I  change  the  comment to  "AIX  recommends to repeat the close call on EINTR" and  push , is that fine with you ?

Best regards, Matthias

> -----Original Message-----
> From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
> Sent: Mittwoch, 4. Juli 2018 13:43
> To: Baesken, Matthias <matthias.baesken at sap.com>; David Holmes
> <david.holmes at oracle.com>; Thomas Stüfe <thomas.stuefe at gmail.com>
> Cc: serviceability-dev (serviceability-dev at openjdk.java.net) <serviceability-
> dev at openjdk.java.net>
> Subject: Re: 8206145 : dbgsysSocketClose - do not restart close if errno is
> EINTR [linux] - was : RE: RFR : 8205959 : Do not restart close if errno is EINTR
> 
> On 04/07/2018 12:37, Baesken, Matthias wrote:
> > Hi all,  here is another  webrev :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8206145.2/
> >
> > - switched to  the coding proposed by Thomas
> > - added a small comment
> >
> The code looks okay but the comment is a bit strange. A simple "AIX
> recommends to repeat the close call on EINTR" should be ignore and drop
> the bug reference.
> 
> -Alan


More information about the serviceability-dev mailing list